AMICI-dev / AMICI

Advanced Multilanguage Interface to CVODES and IDAS
https://amici.readthedocs.io/
Other
108 stars 30 forks source link

zip(... , strict=True) #2412

Closed dweindl closed 5 months ago

dweindl commented 5 months ago

Closes #2410.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 36.70%. Comparing base (b2aeae0) to head (f9703f1).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412/graphs/tree.svg?width=650&height=150&src=pr&token=1bt9lbspzk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) ```diff @@ Coverage Diff @@ ## develop #2412 +/- ## ======================================== Coverage 36.70% 36.70% ======================================== Files 103 103 Lines 14866 14867 +1 Branches 1388 1388 ======================================== + Hits 5456 5457 +1 Misses 9101 9101 Partials 309 309 ``` | [Flag](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [petab](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `36.70% <40.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [...thon/sdist/amici/conserved\_quantities\_demartino.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?src=pr&el=tree&filepath=python%2Fsdist%2Famici%2Fconserved_quantities_demartino.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3NkaXN0L2FtaWNpL2NvbnNlcnZlZF9xdWFudGl0aWVzX2RlbWFydGluby5weQ==) | `0.00% <ø> (ø)` | | | [python/sdist/amici/cxxcodeprinter.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?src=pr&el=tree&filepath=python%2Fsdist%2Famici%2Fcxxcodeprinter.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3NkaXN0L2FtaWNpL2N4eGNvZGVwcmludGVyLnB5) | `73.52% <ø> (ø)` | | | [python/sdist/amici/de\_export.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?src=pr&el=tree&filepath=python%2Fsdist%2Famici%2Fde_export.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3NkaXN0L2FtaWNpL2RlX2V4cG9ydC5weQ==) | `82.49% <ø> (ø)` | | | [python/sdist/amici/petab/conditions.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?src=pr&el=tree&filepath=python%2Fsdist%2Famici%2Fpetab%2Fconditions.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3NkaXN0L2FtaWNpL3BldGFiL2NvbmRpdGlvbnMucHk=) | `97.43% <100.00%> (ø)` | | | [python/sdist/amici/petab/parameter\_mapping.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?src=pr&el=tree&filepath=python%2Fsdist%2Famici%2Fpetab%2Fparameter_mapping.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3NkaXN0L2FtaWNpL3BldGFiL3BhcmFtZXRlcl9tYXBwaW5nLnB5) | `75.39% <ø> (ø)` | | | [python/sdist/amici/petab/pysb\_import.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?src=pr&el=tree&filepath=python%2Fsdist%2Famici%2Fpetab%2Fpysb_import.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3NkaXN0L2FtaWNpL3BldGFiL3B5c2JfaW1wb3J0LnB5) | `52.72% <ø> (ø)` | | | [python/sdist/amici/petab/simulations.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?src=pr&el=tree&filepath=python%2Fsdist%2Famici%2Fpetab%2Fsimulations.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3NkaXN0L2FtaWNpL3BldGFiL3NpbXVsYXRpb25zLnB5) | `91.66% <100.00%> (ø)` | | | [python/sdist/amici/pysb\_import.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?src=pr&el=tree&filepath=python%2Fsdist%2Famici%2Fpysb_import.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3NkaXN0L2FtaWNpL3B5c2JfaW1wb3J0LnB5) | `58.35% <ø> (ø)` | | | [python/tests/petab/test\_petab\_problem.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?src=pr&el=tree&filepath=python%2Ftests%2Fpetab%2Ftest_petab_problem.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3Rlc3RzL3BldGFiL3Rlc3RfcGV0YWJfcHJvYmxlbS5weQ==) | `100.00% <ø> (ø)` | | | [python/tests/test\_petab\_objective.py](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?src=pr&el=tree&filepath=python%2Ftests%2Ftest_petab_objective.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-cHl0aG9uL3Rlc3RzL3Rlc3RfcGV0YWJfb2JqZWN0aXZlLnB5) | `100.00% <ø> (ø)` | | | ... and [6 more](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2412?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | |
dweindl commented 5 months ago

Okay, in some places we seem to rely on different lengths. Related to DAEs and not well documented... :grimacing: TODO