search

AMICI-dev / AMICI

Advanced Multilanguage Interface to CVODES and IDAS
https://amici.readthedocs.io/
Other
108 stars 30 forks source link

Handle reserved names during code-printing #2483

Open dweindl opened 2 months ago

dweindl commented 2 months ago

Avoid symbolic replacements for handling reserved symbols in amici. Instead, only handle them during code printing. This has the advantage that users won't be bothered by changed IDs. This, however, makes it a breaking change for anybody currently relying on "amici*" entity IDs. I don't expect this to be much of a problem, since probably most users would have renamed their model entities to avoid this "amici"-prefixing.

Fixes https://github.com/AMICI-dev/AMICI/issues/2461.

dweindl commented 2 months ago

This won't work for t (amici's time symbol) :(