Closed dweindl closed 1 month ago
Attention: Patch coverage is 47.36842% with 20 lines in your changes missing coverage. Please review.
47.36842%
20 lines
Project coverage is 77.81%. Comparing base (b958cce) to head (86b1c59).
b958cce
86b1c59
Codecov Report
Attention: Patch coverage is
47.36842%
with20 lines
in your changes missing coverage. Please review.Additional details and impacted files
[![Impacted file tree graph](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485/graphs/tree.svg?width=650&height=150&src=pr&token=1bt9lbspzk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) ```diff @@ Coverage Diff @@ ## master #2485 +/- ## ========================================== + Coverage 77.65% 77.81% +0.15% ========================================== Files 324 324 Lines 20933 20941 +8 Branches 1462 1456 -6 ========================================== + Hits 16256 16295 +39 + Misses 4674 4643 -31 Partials 3 3 ``` | [Flag](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `76.21% <47.36%> (+2.79%)` | :arrow_up: | | [cpp_python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `34.08% <36.84%> (-0.01%)` | :arrow_down: | | [petab](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `36.63% <18.91%> (-0.02%)` | :arrow_down: | | [python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `72.36% <42.10%> (+0.16%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [include/amici/model\_dae.h](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485?src=pr&el=tree&filepath=include%2Famici%2Fmodel_dae.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-aW5jbHVkZS9hbWljaS9tb2RlbF9kYWUuaA==) | `72.72% <100.00%> (ø)` | | | [include/amici/model\_ode.h](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485?src=pr&el=tree&filepath=include%2Famici%2Fmodel_ode.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-aW5jbHVkZS9hbWljaS9tb2RlbF9vZGUuaA==) | `100.00% <100.00%> (ø)` | | | [src/amici.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485?src=pr&el=tree&filepath=src%2Famici.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL2FtaWNpLmNwcA==) | `81.41% <ø> (ø)` | | | [src/edata.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485?src=pr&el=tree&filepath=src%2Fedata.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL2VkYXRhLmNwcA==) | `83.07% <100.00%> (+0.92%)` | :arrow_up: | | [src/newton\_solver.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485?src=pr&el=tree&filepath=src%2Fnewton_solver.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL25ld3Rvbl9zb2x2ZXIuY3Bw) | `70.63% <100.00%> (ø)` | | | [src/spline.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485?src=pr&el=tree&filepath=src%2Fspline.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL3NwbGluZS5jcHA=) | `64.89% <ø> (ø)` | | | [src/rdata.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485?src=pr&el=tree&filepath=src%2Frdata.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL3JkYXRhLmNwcA==) | `95.36% <80.00%> (ø)` | | | [src/exception.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485?src=pr&el=tree&filepath=src%2Fexception.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL2V4Y2VwdGlvbi5jcHA=) | `69.69% <33.33%> (-9.10%)` | :arrow_down: | | [src/sundials\_linsol\_wrapper.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485?src=pr&el=tree&filepath=src%2Fsundials_linsol_wrapper.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL3N1bmRpYWxzX2xpbnNvbF93cmFwcGVyLmNwcA==) | `15.31% <0.00%> (ø)` | | | [src/splinefunctions.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485?src=pr&el=tree&filepath=src%2Fsplinefunctions.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL3NwbGluZWZ1bmN0aW9ucy5jcHA=) | `77.59% <29.41%> (+0.14%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2485/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)