search

AMIOL7 / ELME

Apache License 2.0
0 stars 1 forks source link

view-enhancement branch goal and ready-ness #41

Closed vismate closed 1 year ago

vismate commented 1 year ago

I'm ready to start implementing terminating nodes (switches and lights) into the view and I was wondering whether it would be appropriate to continue this branch or start a separate one.

If you recommend implementing those in their own branch, should we merge these changes to main first (If this branch is considered complete by it's author)?

I'd also like to use additions from branch beginning-and-ending-nodes so we should keep that in mind.

pszi commented 1 year ago

I believe it to be ready for continuation. You could either merge the now updated main into the branch or merge this into main then rebase main onto this branch. Both options have the same result, but the first option is less steps so I'd go with that.