AMIOL7 / ELME

Apache License 2.0
0 stars 1 forks source link

Reorganization / Task list #42

Open vismate opened 1 year ago

vismate commented 1 year ago

As the rush of the final week of our project swiftly approaches I feel we need to reorganize ourselves to remain productive.

Since @AMIOL7 fell ill the rest of us need to take over his work too. The following tasks must be worked on and completed:

Task group 1:

Model:

View:

Task group 2:

I'd like to make the initiative and assign @pszi and myself to Task group 1 and @bgdxqi and myself to Task group 2.

If you have other recommendations please share. Once we all agreed upon tasks we can close this issue. We should use this issue (alongside dedicated issues of course) to keep track of our progress.

Ps.: When @AMIOL7 feels better he may join any task he wishes.

pszi commented 1 year ago

@vismate If you need to work with the model, I'd suggest we separate Task group 1, and you only take over in my part in case I will be unable to finish the view in time, but I think

  • display terminating nodes

and

  • display newly implemented nodes in side menu

I can very simply get done in the course of an afternoon.

As for

  • saving and loading user created nodes

if you know how to initiate (de)serialization of the working graph, you could have a crack at that, also if we want saved graphs to be able to be dragged in as nodes, you can look up the API docs on how to make Menus have dynamic content, and if you have a solution, feel free to share as I would like to be included, or at least informed at that.

vismate commented 1 year ago

I think we should use the task listing above to keep track of our progress. Also, I've implemented whats needed for our final assignment!!

AMIOL7 commented 1 year ago

@vismate is deserialization is really needed? If the file will contain truth table, wouldn't it be better to directly access it in simulation loop?

AMIOL7 commented 1 year ago

Also, wouldn't it be better, if release is created only if at least unit tests are successful?

vismate commented 1 year ago

@vismate is deserialization is really needed? If the file will contain truth table, wouldn't it be better to directly access it in simulation loop?

What I mean by deserialization here is to load that truth table and store it in memory. I don't think reading a file on each update would be appropriate.

Also, the savefile would also store port labels which need to be loaded to display them.

vismate commented 1 year ago

Also, wouldn't it be better, if release is created only if at least unit tests are successful?

The release job depends on unit tests. I believe this means unit tests must not fail in order to create a new release.

Correct me if thats not correct.

AMIOL7 commented 1 year ago

Also, wouldn't it be better, if release is created only if at least unit tests are successful?

The release job depends on unit tests. I believe this means unit tests must not fail in order to create a new release.

Correct me if thats not correct.

Yes, that is correct.

AMIOL7 commented 1 year ago

Sorry, my bad. Did not see a "needs" line of code in your commit

AMIOL7 commented 1 year ago

I have taken a look at the pipeline, there is nothing to fix or improve

AMIOL7 commented 1 year ago

@vismate When are you going to submit the last assignment?

vismate commented 1 year ago

@vismate When are you going to submit the last assignment?

After finishing the required documentation. I'll be done with it later today.