Closed ezackr closed 9 months ago
There are so many files changed that it is impossible to review this PR on GitHub. I'll review the mentioned files locally and see if all tests pass.
@ezackr Please, let me know when you have correctly uploaded all projects sources. Right now there are several projects missing, so I cannot configure the final E2E test. Once it's done, I'll configure it, run it locally, and run it in CI. If all checks pass, then @mernst may review this PR and we may eventually merge it.
It seems that you have included several methods in the oraclegrammar.custom.Parser
class. These methods don't seem to have anything to do with the internal structure (grammar) of oracles, which is handled with Xtext-related libraries. That being the case, I would move them out to a different class. You may use the StringUtils class or create another one if you think it's worth it.
It seems that you have included several methods in the
oraclegrammar.custom.Parser
class. These methods don't seem to have anything to do with the internal structure (grammar) of oracles, which is handled with Xtext-related libraries. That being the case, I would move them out to a different class. You may use the StringUtils class or create another one if you think it's worth it.
Sorry about that. These methods are from the original version and were not used in the new version, so they have been removed entirely.
~NOTE: Please review part 1 before this request.~
Overview: We provide a brief description of relevant files in this pull request.
data/oracles/OracleDatapointBuilder.java
: a builder class for creatingOracleDatapoint
objects.data/oracles/ProjectOracleGenerator.java
: a class for generating allOracleDatapoint
objects in a given project, using the provided JDoctor conditions.data/records/*.java
: various records for storing tuples of tokensdata/ProjectInitializer.java
: a class for deserializing Projects fromdata/repos/input_projects.json
using Jackson.util/javaparser/DatasetUtils.java
: a collection of utilities for gettingOracleDatapoint
fields.Unit tests have been added for individual functionalities. Current version passes CI (implementation is consistent with legacy version).
EDIT: This has been updated to reflect the new records implementation. Additionally, we have closed PR2 (which did not use records) to avoid redundant comments and reviews.