Correctly handle `null` and variables containing "instanceof"

AML14 / tratto

2 stars 1 forks source link

Correctly handle `null` and variables containing "instanceof" #73

Closed mernst closed 1 year ago

AML14 commented 1 year ago

Both this PR and PR #72 are based on the main branch, which does not integrate the E2E tests. Off the top of my head, I'm not sure if these changes may break something. Is it okay if we wait until merging PRs #41, #43 and the tratto-program branch (which I guess we're doing soon) and then merge this?

mernst commented 1 year ago

The profusion of branches and pull requests is a problem that is not solved by delaying more merges. :smiley: I think that if a branch is ready, it should be merged, and in general branches should not be long-lived. If you are worried about the impact of this change on other branches, then you can pull it into those branches to ensure that this pull request has no negative consequences. That will make debugging any differences easy.