Closed renovate[bot] closed 8 months ago
Because you closed this PR without merging, Renovate will ignore this update (==1.26.18
). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps
array of your Renovate config.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.
This PR contains the following updates:
==1.26.6
->==1.26.18
GitHub Vulnerability Alerts
CVE-2023-43804
urllib3 doesn't treat the
Cookie
HTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify aCookie
header and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly.Users must handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the
Cookie
header, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach.Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
Cookie
header on requests, which is mostly typical for impersonating a browser.Remediation
redirects=False
when sending requests.Cookie
header.CVE-2023-45803
urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like
POST
) toGET
as is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.From RFC 9110 Section 9.3.1:
Affected usages
Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.
Both of the following conditions must be true to be affected by this vulnerability:
Remediation
You can remediate this vulnerability with any of the following steps:
redirects=False
.redirects=False
and handle 303 redirects manually by stripping the HTTP request body.Release Notes
urllib3/urllib3 (urllib3)
### [`v1.26.18`](https://togithub.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12618-2023-10-17) [Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.17...1.26.18) \==================== - Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses. ### [`v1.26.17`](https://togithub.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12617-2023-10-02) [Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.16...1.26.17) \==================== - Added the `Cookie` header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via `Retry.remove_headers_on_redirect`. (`#3139Configuration
📅 Schedule: Branch creation - "" in timezone Europe/Zurich, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled because a matching PR was automerged previously.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.