AMLab-Amsterdam / lie_learn

Computations involving Lie groups and harmonic analysis
MIT License
190 stars 47 forks source link

tests fails when importing nfsft from pynfft #11

Closed mariogeiger closed 1 month ago

mariogeiger commented 4 years ago

The tests does not pass when I try to build the package in order to create a conda-forge repository: https://github.com/conda-forge/staged-recipes/pull/10861

I get the following error: ImportError: cannot import name 'nfsft' from 'pynfft' ($PREFIX/lib/python3.7/site-packages/pynfft/__init__.py)

bkmi commented 4 years ago

The reason is that the package is not listed in requirements and (after trying to add it to requirements) is semi-complicated to install.

Is it possible to remove this test case?

bkmi commented 4 years ago

However there are other failing test cases...

lie_learn/spectral/tests/test_SO3_FFT_Naive.py:112: AssertionError lie_learn/spectral/tests/test_SO3_FFT_Naive.py:157: AssertionError