AMLab-Amsterdam / lie_learn

Computations involving Lie groups and harmonic analysis
MIT License
190 stars 47 forks source link

Remove generated C files from the repository #31

Closed kalekundert closed 1 month ago

kalekundert commented 2 months ago

Currently, the repository contains 4 Cython-generated C source files. I think there are a few good reasons to remove these files:

I can think of one possible reason to not remove these files, which is that they make the software more reproducible by ensuring that everyone gets the same generated source. But I don't think this is a very compelling reason:

I expect that merging either this PR or #30 will cause merge conflicts for the other. If/when this happens, I'll fix the conflicts.

tscohen commented 1 month ago

I agree, it makes more sense to remove these. Not sure why I chose to include them.... 7 years ago :)

Thanks for your contribution!