Closed chadhanna closed 6 years ago
Actually maybe this patch:
channa@channa:~/git/Analysis/AmonPy$ git diff setup.py
diff --git a/AmonPy/setup.py b/AmonPy/setup.py
index ae641ce..ae5f4d4 100644
--- a/AmonPy/setup.py
+++ b/AmonPy/setup.py
@@ -7,7 +7,5 @@ setup(name = "AmonPy",
description='AMON Analysis Code',
author='Miles Smith, Gordana Tesic',
author_email='mus44@psu.edu, gut10@psu.edu',
- py_modules = [],
- package_dir = {'': 'amonpy'},
- packages =['anal', 'dbase', 'ops', 'sim', 'tools'],
- scripts = ['amonpy/ops/run_archival.py', 'amonpy/ops/run_basic_sim.py'],)
+ packages =['amonpy.anal', 'amonpy.dbase', 'amonpy.ops', 'amonpy.sim', 'amonpy.tools']
+)
Currently amonpy installs a fairly polluted namespace by making generic packages called 'dbase', etc. I think these should be installed under amonpy. So you would import dbase as
instead of
While this change is a bit painful, it is good form in general and better to do now before we have a lot of users.
Here is a proposed change to setup.py