AMONCode / Analysis

Repository for the AMON software
2 stars 0 forks source link

change setup #1

Closed chadhanna closed 6 years ago

chadhanna commented 10 years ago

Currently amonpy installs a fairly polluted namespace by making generic packages called 'dbase', etc. I think these should be installed under amonpy. So you would import dbase as

from amonpy import dbase

instead of

import dbase.

While this change is a bit painful, it is good form in general and better to do now before we have a lot of users.

Here is a proposed change to setup.py

channa@chad:~/git/Analysis/AmonPy_0.2$ git diff setup.py
diff --git a/AmonPy_0.2/setup.py b/AmonPy_0.2/setup.py
index 5263136..148a532 100644
--- a/AmonPy_0.2/setup.py
+++ b/AmonPy_0.2/setup.py 
@@ -7,7 +7,6 @@ setup(name = "AmonPy",
       description='AMON Analysis Code',
       author='Miles Smith, Gordana Tesic',
       author_email='mus44@psu.edu, gut10@psu.edu',
-      py_modules = [],
-      package_dir = {'': 'amonpy'},
-      packages =['anal', 'dbase', 'ops', 'sim', 'tools'],
-      scripts = ['amonpy/ops/run_archival.py', 'amonpy/ops/run_basic_sim.py'],)
+      packages = ['amonpy', 'amonpy.anal', 'amonpy.dbase',  'amonpy.sim', 'amonpy.tools'],
+      scripts = ['amonpy/ops/run_archival.py', 'amonpy/ops/run_basic_sim.py'],
+      )
chadhanna commented 9 years ago

Actually maybe this patch:

channa@channa:~/git/Analysis/AmonPy$ git diff setup.py
diff --git a/AmonPy/setup.py b/AmonPy/setup.py
index ae641ce..ae5f4d4 100644
--- a/AmonPy/setup.py
+++ b/AmonPy/setup.py
@@ -7,7 +7,5 @@ setup(name = "AmonPy",
       description='AMON Analysis Code',
       author='Miles Smith, Gordana Tesic',
       author_email='mus44@psu.edu, gut10@psu.edu',
-      py_modules = [],
-      package_dir = {'': 'amonpy'},
-      packages =['anal', 'dbase', 'ops', 'sim', 'tools'],
-      scripts = ['amonpy/ops/run_archival.py', 'amonpy/ops/run_basic_sim.py'],)
+      packages =['amonpy.anal', 'amonpy.dbase', 'amonpy.ops', 'amonpy.sim', 'amonpy.tools']
+)