search

AMP-SCZ / dpdash

Deep phenotyping dashboard
Other
2 stars 1 forks source link

665 handle null consent date #673

Closed JackVCurtis closed 8 months ago

JackVCurtis commented 8 months ago

This PR fixes initialization of the participant consent date from the metadata, including when the date is missing or set to an invalid value. It also handle the days in study on the participants view by looking at the greatest day value in the dayData array. I added an unrelated fix to initializing the admin account in development, since it was causing issues for me locally.

JackVCurtis commented 8 months ago

I see what you mean about our architecture making this more difficult. Out of curiosity, how hard would it be to change the architecture such that we didn't have the nested day data array?

Not as difficult as the migration to DocumentDB but still involves running a migration script against the staging database, which will have to be run AWS side and will require at minimum a new Github Action in addition to the refactor.