search

AMP-SCZ / dpdash

Deep phenotyping dashboard
Other
2 stars 1 forks source link

Add study page #718

Closed Elkrival closed 7 months ago

Elkrival commented 7 months ago

@mikestone14 I've noticed that the icons available from material are different than what's in figma. Where do we get the right ones..? might Berfin own them..?

Figma

Screenshot 2024-03-29 at 1 31 00 PM

Material

Screenshot 2024-03-29 at 1 32 45 PM
JackVCurtis commented 7 months ago

Should we also have a test for this page? Not sure if we have page level tests in the app yet.

We do have page tests, but they're pretty basic right now. E.g. testing that the page renders rather than testing dynamic behavior on the page.

Elkrival commented 7 months ago

Should we also have a test for this page? Not sure if we have page level tests in the app yet.

We have some... this is the diff for this one https://github.com/AMP-SCZ/dpdash/pull/718/files#diff-f53cd4dd7b90bcad02763df5dd2790d149c0012245ec6066103f50f113ffe6f1