search

AMP-SCZ / dpdash

Deep phenotyping dashboard
Other
2 stars 1 forks source link

add network filter that limits available sites #722

Closed JackVCurtis closed 6 months ago

JackVCurtis commented 6 months ago

This PR adds a Network filter with two options, PRESCIENT and ProNET. Each site is associated with one of these networks through a new constant, and when a network is selected the available sites for the site filter will be limited to the sites for that network.

Screenshot 2024-04-02 at 11 40 46 AM
Elkrival commented 6 months ago

@JackVCurtis Can you try running this using a chart with data..? I pulled your branch and I get errors

Screenshot 2024-04-02 at 12 25 53 PM Screenshot 2024-04-02 at 12 25 48 PM
JackVCurtis commented 6 months ago

Yeah, I'll try. My data set is weird and I've had a hard time getting data to come back, but thanks for the catch.

JackVCurtis commented 6 months ago

@JackVCurtis Can you try running this using a chart with data..? I pulled your branch and I get errors

Screenshot 2024-04-02 at 12 25 53 PM Screenshot 2024-04-02 at 12 25 48 PM

I got a working chart for my data set and tracked down the bug: 93df04e

Looks like the issue was a move from == to === without converting the value from string to number, introduced when we added linting/formatting.