search

AMP-SCZ / eeg-qc-dash

Plotly/Dash based web application for checking quality of EEGs
Apache License 2.0
2 stars 1 forks source link

ses-{} for AVG should be dated today #2

Closed tashrifbillah closed 2 years ago

tashrifbillah commented 2 years ago

ses-00000000 does not help with date filtering. It should be dated today or the last EEG date of respective sites.

cc @speroNCIRE

speroNCIRE commented 2 years ago

The ses-000000 will only exist for the averages. They probably don’t need to be filterable. I haven’t thought it all the way through. The idea was that you would compare a single EEG session or perhaps range of sessions using the filters you’ve created, against either the average for that site, or the average across all sites. I can see some problems arising if we put in an actual date for the averages and make them subject to date range filters. For example if I made a brand new up to date average that got today’s date, and wanted to look at all data collected in December compared to the new average, there wouldn’t be a way to do that if the same date range was applying to both. If we could separately filter individual sessions and averages by date range, that would be really versatile, and then I could date-stamp the averages with the date on which they were created, but that might be more complicated than we need. I’ll check in with my team, but I think we can get away with only one copy of the average images per site and study that will periodically get overwritten as new data is acquired.

Unrelatedly, is there a policy on which AMP SCZ GitHub repositories are public? I notice some, most but not all are. I’m not sure the eeg-processing needs to be, at least at this stage.

Best,

Spero

From: Tashrif @.> Sent: Thursday, March 3, 2022 1:16 PM To: @.> Cc: Spero @.>; @.> Subject: [AMP-SCZ/eeg-qc-dash] ses-{} for AVG should be dated today (Issue #2)

ses-00000000 does not help with date filtering. It should be dated today or the last EEG date of respective sites.

cc @speroNCIREhttps://github.com/speroNCIRE

— Reply to this email directly, view it on GitHubhttps://github.com/AMP-SCZ/eeg-qc-dash/issues/2, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVRY6LWAHDSR6BF23DLJMQTU6ET3TANCNFSM5P3UOD5A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>