search

AMP-SCZ / eeg-qc-dash

Plotly/Dash based web application for checking quality of EEGs
Apache License 2.0
2 stars 1 forks source link

date range question #36

Open speroNCIRE opened 8 months ago

speroNCIRE commented 8 months ago

Tashrif, I think I've seen you only set the "earliest" date and run a filter successfully. This doesn't work for me and I need to set the "latest" date too to get a date filter to run. Maybe it's a browser-dependent issue. Would it be easy to initially fill the latest date box with the current date?

tashrifbillah commented 8 months ago

Hi Spero, I think it could be done by adjusting the following codes:

https://github.com/AMP-SCZ/eeg-qc-dash/blob/1fd96362024d9ad36eb67a1b704eb400a427df13/app.py#L249-L259

I shall look into it more.

speroNCIRE commented 8 months ago

Hi Tashrif,

This isn’t a big deal & it’s no problem to type in dates. I was just wondering if we could initialize the start date blank and the end date on the current day? Am I right that when you type in a start date and leave the end date blank the filter works for you? I’m pretty sure I’ve seen you do that on Zoom, but it’s never worked on my end.

-Spero

From: Tashrif Billah @.> Sent: Tuesday, December 19, 2023 12:44 PM To: AMP-SCZ/eeg-qc-dash @.> Cc: Spero Nicholas @.>; Author @.> Subject: [External] - [External] Re: [AMP-SCZ/eeg-qc-dash] date range question (Issue #36)

Hi Spero, I think it could be done by adjusting the following codes:

https://github.com/AMP-SCZ/eeg-qc-dash/blob/1fd96362024d9ad36eb67a1b704eb400a427df13/app.py#L249-L259

I shall look into it more.

— Reply to this email directly, view it on GitHubhttps://github.com/AMP-SCZ/eeg-qc-dash/issues/36#issuecomment-1863446594, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVRY6LRPAXKHAXPJOI2MTE3YKH4CFAVCNFSM6AAAAABA3RALYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRTGQ2DMNJZGQ. You are receiving this because you authored the thread.Message ID: @.***>

tashrifbillah commented 8 months ago

Am I right that when you type in a start date and leave the end date blank the filter works for you?

Hi Spero, this convenience was probably in place in the early days of this app development. In recent times (last 1 year), it is not the case. Currently, there is an and in our code--which means both dates are required: https://github.com/AMP-SCZ/eeg-qc-dash/blob/1fd96362024d9ad36eb67a1b704eb400a427df13/app.py#L312-L315

If one is left blank, it shows all EEGs acquired till date. But again, your feedback is valid and doable. I just need to find a time to work on it. Also, we need to fix the improper autosave feature. I am thinking which one of the two we should do first.

speroNCIRE commented 8 months ago

Hi Tashrif,

For sure the autosave feature would be a higher priority than working on the date range filter. I think I’m the only one who uses that regularly.

Spero