Closed tashrifbillah closed 2 years ago
Also **kwargs
should be removed from all of below:
1. / 2. We are not using behav_qc
or hearing
datatype, and they are left as they are. Mindlamp goes under phone
datatype. We can also change this folder name, which we need to discuss with Justin.
kwargs
If you don't see any use of kwargs
, I'm up for removing this from our functions.
Can you answer my question #1
?
Can you answer my question #1?
We are not using behav_qc
datatype for our U24 project and I think it's safe to ignore this in our AMP-SCZ/lochness
. What do you think?
Okay thank you.
For #2
, if hearing
and mindlamp
go to their respective folders, then the following:
just reduces to:
if 'raw' in Templates[data_type]:
# restructure root
base = Path(base).parent.parent / study / 'raw'
raw_folder = base / phoenix_id / Templates[data_type]
if 'processed' in Templates[data_type]:
# restructure root
base = Path(base).parent.parent / study / 'processed'
processed_folder = base / phoenix_id / Templates[data_type]
That said, we should push for hearing
and mindlamp
to go to their respective folders for the simplicity of coding.
That said, we should push for hearing and mindlamp to go to their respective folders for the simplicity of coding.
hearing
in AMP-SCZ project and this does not affect our pipeline.mindlamp
, are you suggesting the mindlamp
data to store data under mindlamp
folder rather than the phone
folder?I know Habib already started working on his pipeline according to phone
directory name, we should confirm if this change will affect any other pipelines with the group. I have brought it up in the DPACC slack channel.
raw
?https://github.com/AMP-SCZ/lochness/blob/759298eace405621a4091642f864431924b999f9/lochness/tree/__init__.py#L26-L29
https://github.com/AMP-SCZ/lochness/blob/759298eace405621a4091642f864431924b999f9/lochness/tree/__init__.py#L46-L49
https://github.com/AMP-SCZ/lochness/blob/759298eace405621a4091642f864431924b999f9/lochness/tree/__init__.py#L74-L77
I was expecting to see
hearing
andmindlamp
words in them.