search

AMP-SCZ / utility

Storehouse for all utility scripts
Apache License 2.0
0 stars 4 forks source link

fix: filtering MRI DB - 2 #106

Closed tashrifbillah closed 4 months ago

tashrifbillah commented 4 months ago

Only substantial modifications suggested in PR #96

tashrifbillah commented 4 months ago

Hi @kcho , are these all the changes you suggested? After you confirm, I shall propose ideas.

tashrifbillah commented 4 months ago

Hi @kcho , are these all the changes you suggested? After you confirm, I shall propose ideas.

Can you look again?

tashrifbillah commented 4 months ago

Now that Kevin has confirmed the substantial changes he originally proposed, let's review.

tashrifbillah commented 4 months ago

Tashrif is testing get_mri_status() now. Then he plans to test Kevin's unittest from PR #96 .

tashrifbillah commented 4 months ago

get_mri_status() test is complete.

But unittest fails because it cannot recognize dict1 within get_value() that is within subject_files_status_for_dpdash2.py:

cd utility
python -m unittest tests.test_subject_files_status_for_dpdash2.test_run_get_mri_status_test_all

So Kevin is right. But we have not written our program for such tests. We can enhance it in future. For now, all tests could be run by the main program manually.

tashrifbillah commented 4 months ago

I think we are experiencing a GitHub outage. Shall merge it shortly: image

tashrifbillah commented 4 months ago

Kevin, I have merged it manually in /data/predict1/utility/ so you can continue your work. Thanks.

cc Dheshan.

tashrifbillah commented 4 months ago

This is interesting. After merging in the backend, I pushed up the commit and that merged it in the front-end too!