AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.
http://amrex-astro.github.io/Castro
Other
298 stars 97 forks source link

[NEVER MERGE THIS!!!] constexpr the runtime parameters #2702

Closed zingale closed 7 months ago

zingale commented 8 months ago

PR summary

This is an experiment to see if keeping the runtime parameters as constexpr instead of managed helps with later versions of ROCm. Note: the values are compiled in, so they will need to be hacked to override the defaults for a particular problem.

PR motivation

PR checklist

zingale commented 8 months ago

run this together with this Microphysics PR: https://github.com/AMReX-Astro/Microphysics/pull/1441

these hardcode the parameters for the subchandra problem, which is one of the problems that fails with later versions of ROCm

zingale commented 8 months ago

The way this works is that we pass --constexpr to the python scripts that write the parameters headers. This changes them to declare them as constexpr instead of (extern) managed. The values are no hardcoded in, and there are no parmparse queries for them.