remove some deprecated AMReX constants / macros

AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.

http://amrex-astro.github.io/Castro

Other

298 stars 97 forks source link

remove some deprecated AMReX constants / macros #2719

Closed zingale closed 7 months ago

zingale commented 7 months ago

PR summary

PR motivation

This prepares us for https://github.com/AMReX-Codes/amrex/pull/3713

PR checklist

[ ] test suite needs to be run on this PR
[ ] this PR will change answers in the test suite to more than roundoff level
[ ] all newly-added functions have docstrings as per the coding conventions
[ ] the CHANGES file has been updated, if appropriate
[ ] if appropriate, this change is described in the docs

WeiqunZhang commented 7 months ago

I was also preparing for this yesterday. I just rebased my branch on yours. You might be able to cherry-pick the HEAD. https://github.com/WeiqunZhang/Castro/tree/amrex_prefix

WeiqunZhang commented 7 months ago

Note that I have not tested the patch in any ways.

zingale commented 7 months ago

I've merged your changes. I didn't do Diagnostics or the radiation stuff yet, so that's in now. I didn't do the Detonation yet, because of #2722 but I'll fix that once that fix is in.

zingale commented 7 months ago

all the regression tests are passing now.