search

AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.
http://amrex-astro.github.io/Castro
Other
297 stars 99 forks source link

shock detection changes seem to make hybrid Riemann worse #2721

Closed zingale closed 7 months ago

zingale commented 7 months ago

We are getting some artifacts now with the odd-even problem: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2024-01-21/oddeven-2d-hybrid.html

zingale commented 7 months ago

the issue seems to be that our "shock" tag is now 1 zone narrower (3 zones wide instead of 4):

image

(top is new, bottom is old)

This is something that can be adjusted by setting the threshold parameter

zingale commented 7 months ago

indeed, changing the threshold from the default 2/3 down to 1/2 seems to make the problem look good again:

image

(left is castro.shock_detection_threshold=0.66666, right is castro.shock_detection_threshold=0.5)

zingale commented 7 months ago

closing this, as it just seems to be a threshold issue