AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.
http://amrex-astro.github.io/Castro
Other
297 stars 99 forks source link

Update documentation regarding species sources and normalization #2742

Closed KiranEiden closed 6 months ago

KiranEiden commented 6 months ago

PR summary

This PR updates the Hydrodynamics section documentation to highlight that sources for passive variables in the conserved state are off by default. It also removes the reference to castro.normalize_species, which does not appear to be a valid runtime parameter any longer. I am happy to introduce additional documentation regarding the species normalization if that would be helpful -- my understanding is that it is on by default now.

PR checklist

zingale commented 6 months ago

Oh, I missed that there was only a single `

image

can you fix the typesetting of USE_SPECIES_SOURCES in a new PR?

KiranEiden commented 6 months ago

Sure, sorry about that. I’ll do that later tonight.