search

AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.
http://amrex-astro.github.io/Castro
Other
300 stars 98 forks source link

split c-linter action in 2 #2746

Closed zingale closed 3 months ago

zingale commented 9 months ago

Right now the c-linter action does clang-tidy and claims to do cppcheck. We should split it in two.

For the clang-tidy, we should use the build process that is in AMReX currently (USE_CLANG_TIDY=TRUE).

For cppcheck, we should make sure it is actually running and make an artifact from the output.

yut23 commented 8 months ago

One of the considerations is that cppcheck uses a compilation database to pick up the right options and files. It might be possible to do something with make print-CXXFLAGS etc instead, but I'm not sure.

zingale commented 6 months ago

we now have a separate clang-tidy action, so I am not sure if we even need this one anymore.