fix a bounds issue in sources in true SDC

AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.

http://amrex-astro.github.io/Castro

Other

299 stars 97 forks source link

fix a bounds issue in sources in true SDC #2775

Closed zingale closed 6 months ago

zingale commented 6 months ago

PR summary

We were sometimes reading invalid data depending on what options were set.

PR motivation

PR checklist

[ ] test suite needs to be run on this PR
[ ] this PR will change answers in the test suite to more than roundoff level
[ ] all newly-added functions have docstrings as per the coding conventions
[ ] the CHANGES file has been updated, if appropriate
[ ] if appropriate, this change is described in the docs

zingale commented 6 months ago

note: review with whitespace off, since I also fixed some formatting to make it easier to read

zingale commented 6 months ago

all SDC tests pass: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2024-03-14-003/index.html