AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.
http://amrex-astro.github.io/Castro
Other
299 stars 97 forks source link

define runtime params in .cpp instead of *_declares.H #2797

Closed zingale closed 6 months ago

zingale commented 6 months ago

This fixes a potential ODR problem with *_declares.H, which is where we did the actual definition of the runtime parameters. Now we output a single runtime_params.cpp that has all of the runtime parameters defined in source instead of headers.

This also removes padding from the struct that we can alternately use for runtime params

PR summary

PR motivation

PR checklist

yut23 commented 6 months ago

We should sort namespaces as well, on line 139.

zingale commented 6 months ago

added the sort on namespaces

zingale commented 6 months ago

okay, I removed the redundant sorts