make clean should remove temporary .cpp files too

AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.

http://amrex-astro.github.io/Castro

Other

293 stars 99 forks source link

make clean should remove temporary .cpp files too #2812

Closed zingale closed 3 months ago

zingale commented 3 months ago

PR summary

PR motivation

PR checklist

[ ] test suite needs to be run on this PR
[ ] this PR will change answers in the test suite to more than roundoff level
[ ] all newly-added functions have docstrings as per the coding conventions
[ ] the CHANGES file has been updated, if appropriate
[ ] if appropriate, this change is described in the docs

zingale commented 3 months ago

I guess this is kinda redundant though, since it appears that amrex removes all of tmp_build_dir

maybe this is a vestige from when clean and realclean did different things?

yut23 commented 3 months ago

Also, CASTRO_AUTO_SOURCE_DIR will only be correct if you specify all the right variables (USE_MPI, DEBUG, etc.) when you call make clean.

zingale commented 3 months ago

right. I think that this goes back to the old difference between make clean and make realclean, which no longer exists anymore