AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.
http://amrex-astro.github.io/Castro
Other
293 stars 99 forks source link

potentially more issues with reties and amr.subcycle_mode = None #2823

Closed zingale closed 2 months ago

zingale commented 2 months ago

It looks like we need to update retry_advance_ctu() to do save_data_for_retry() and zero out the fluxes on all levels if we are not doing AMR subcycling.

We probably also need to update the time level stuff after the subcycling is complete in subcycle_advance_ctu()

zingale commented 2 months ago

these are fixed in #2824

zingale commented 2 months ago

this seems to be fixed now