fix the wdmerger case when the 2 stars are very close - Githubissues

AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.

http://amrex-astro.github.io/Castro

Other

299 stars 97 forks source link

fix the wdmerger case when the 2 stars are very close #2829

Closed zingale closed 5 months ago

zingale commented 5 months ago

the initialization was overlapping and doing bad things now we simply look at which model provides the largest density at a location and use that.

PR summary

PR motivation

PR checklist

[ ] test suite needs to be run on this PR
[ ] this PR will change answers in the test suite to more than roundoff level
[ ] all newly-added functions have docstrings as per the coding conventions
[ ] the CHANGES file has been updated, if appropriate
[ ] if appropriate, this change is described in the docs

zingale commented 5 months ago

Here's the wdmerger 2D collision test case now:

compare to the image in #2824

zingale commented 5 months ago

tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2024-04-20/index.html

zingale commented 5 months ago

velocities updated, but I want to rerun the suite on this now.