fix pstar convergence in exact_riemann use std::abs() - Githubissues

AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.

http://amrex-astro.github.io/Castro

Other

299 stars 97 forks source link

fix pstar convergence in exact_riemann use std::abs() #2898

Closed zingale closed 2 months ago

zingale commented 3 months ago

PR summary

This eliminates the test on ustar_l - ustar_r, since that is tricky when u -> 0, and is not needed, since the root solve is on pstar.

test2 now converges.

PR motivation

PR checklist

[ ] test suite needs to be run on this PR
[ ] this PR will change answers in the test suite to more than roundoff level
[ ] all newly-added functions have docstrings as per the coding conventions
[ ] the CHANGES file has been updated, if appropriate
[ ] if appropriate, this change is described in the docs