2D spherical geometry - Githubissues

We want to add 2D spherical geometry $(r, \theta)$ on the grid with axisymmetry in $\phi$.

The following tasks need to be done:

[x] update the geometry source terms in Castro/Source/sources/Castro_geom.cpp to have the geometric terms (done in https://github.com/AMReX-Astro/Castro/pull/2955)
[ ] add the primitive variable source terms (perhaps via #2473)
[ ] make sure that the geometry terms are included in the transverse flux correction functions
[ ] add the geometry factors to diffusion
[x] update artifical viscosity (done in https://github.com/AMReX-Astro/Castro/pull/2954)
[ ] update the shock detection algorithm
[ ] add the correct cross product for the Coriolis force in the rotational source term
[x] update AMReX to know about the area and volume factors (done in https://github.com/AMReX-Codes/amrex/pull/4141)
[x] make constant gravity work in the radial direction (done in https://github.com/AMReX-Astro/Castro/pull/2957)
[x] update our local area and volume functions (in Castro_util.H) to have the same factors (done in https://github.com/AMReX-Astro/Castro/pull/2953)
[x] address mom_flux_has_p (done in https://github.com/AMReX-Astro/Castro/pull/2958)
[ ] add a ptheta flux register analogous to the pradial one
[ ] make sure that the interpolation in AMReX uses the edge volume weights (these were inlined--see discussion in https://github.com/AMReX-Codes/amrex/pull/4141)

AMReX-Astro / Castro