add P_theta flux register and scale pressure using area and volume

AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.

http://amrex-astro.github.io/Castro

Other

302 stars 98 forks source link

add P_theta flux register and scale pressure using area and volume #2960

Open zhichen3 opened 2 months ago

zhichen3 commented 2 months ago

PR summary

This pr adds P_theta flux similar to P_radial for spherical 2d. This addresses issue #2927

PR motivation

PR checklist

[ ] test suite needs to be run on this PR
[ ] this PR will change answers in the test suite to more than roundoff level
[ ] all newly-added functions have docstrings as per the coding conventions
[ ] the CHANGES file has been updated, if appropriate
[ ] if appropriate, this change is described in the docs

zingale commented 2 months ago

this might be related: https://github.com/AMReX-Astro/Castro/issues/2803

zhichen3 commented 2 months ago

I think this is fine too. I just copied what's there for P_radial and added a corresponding version for P_theta.