AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.
http://amrex-astro.github.io/Castro
Other
302 stars 98 forks source link

address timestep and cfl violation for Spherical2D #2962

Closed zhichen3 closed 2 months ago

zhichen3 commented 2 months ago

PR summary

address #2927 . Change timestep and cfl_violation so we use rdtheta, rdx[1], which is the physical cell length instead of just dx[1] for cell length in theta direction for spherical 2d.

PR motivation

PR checklist

zhichen3 commented 2 months ago

we might need to change things in radiation, especially since dx.array is passed on to estimate_gamrPr. I could just change it to rdtheta, but I don't really know if its the right thing to do. It's probably only supported for cartesian?