pass in the correct dloga when doing tracing

AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.

http://amrex-astro.github.io/Castro

Other

302 stars 98 forks source link

pass in the correct dloga when doing tracing #2994

Closed zhichen3 closed 5 days ago

zhichen3 commented 1 week ago

PR summary

computes dloga in y-direction and pass in the correct dloga for the corresponding dir. This was missed in pr #2964 .

PR motivation

PR checklist

[ ] test suite needs to be run on this PR
[ ] this PR will change answers in the test suite to more than roundoff level
[ ] all newly-added functions have docstrings as per the coding conventions
[ ] the CHANGES file has been updated, if appropriate
[ ] if appropriate, this change is described in the docs

zingale commented 1 week ago

does this fix any issues? or it is just safely zeroing out dlogA for non-curvilinear geometries?

zhichen3 commented 1 week ago

this fixes the issue where we only computed and used dloga in the 0-direction, so we were using dlogaX in both x- and y- normal direction when we do the tracing with the primitive geometric terms for rho, pres and rhoe. Now we compute dloga in both 0 and 1 direction and pass in the corresponding dloga.

zingale commented 1 week ago

oh right. I think I was looking at a commit and now the full changes.

zingale commented 1 week ago

there's roundoff diffs for one problem: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2024-11-14-001/bwp.html