search

AMReX-Astro / Castro

Castro (Compressible Astrophysics): An adaptive mesh, astrophysical compressible (radiation-, magneto-) hydrodynamics simulation code for massively parallel CPU and GPU architectures.
http://amrex-astro.github.io/Castro
Other
299 stars 97 forks source link

better treatment for inflow BCs #687

Open zingale opened 4 years ago

zingale commented 4 years ago

For inflow BCs, we should adopt the strategy from Maestro and others where the ghost cell value represents the interface value, and not the cell-center. And then we should use modified stencils at the edge to ensure that we see the correct inflow state.

maxpkatz commented 4 years ago

It would also be good to be more consistent about this throughout the code because we already treat the boundary values on phi as edge values.