Closed zingale closed 5 months ago
Looked through and all the r
's are either indexing BaseStateArray
's or are being used to calculate an int
like g = r + ng;
.
I think it would be best to just change the loops from long
to int
.
Further down (line 442) there are more loops that could similarly be changed. Here j
is only used to compute int r = j + lo;
ParallelFor(hi - lo + 1, [=] AMREX_GPU_DEVICE(long j) {
Real slope = 0.0;
int r = j + lo;
okay, do you want to PR this?
Yes, I can get a PR going
In
MaestroMakeEdgeState.cpp
, we do:but we have a lot of implicit narrowing to
int
here. An issue is that we use these ints to index into the base state arrays:How do we deal with this? Do we really need the
long
there in the loop? If so, do we need to change the base state arrays to take along
as an index?