search

AMReX-Astro / MAESTROeX

A C++ low Mach number stellar hydrodynamics code
https://amrex-astro.github.io/MAESTROeX/
BSD 3-Clause "New" or "Revised" License
40 stars 22 forks source link

enthalpy_pred_types that predict T seem to be missing T on edge? #444

Open zingale opened 4 months ago

zingale commented 4 months ago

If you look at the code in MaestroEnthalpyAdvance.cpp, we do:

  // needs to be done after the state was returned to the full state.
  if ((enthalpy_pred_type == predict_T_then_rhohprime) ||
       (enthalpy_pred_type == predict_T_then_h) ||
       (enthalpy_pred_type == predict_Tprime_then_h)) {
       `(sedge, rho0_edge_old, rhoh0_edge_old, rho0_edge_new,
                     rhoh0_edge_new);
  }

but in HfromRhoTedge, it is not clear where we are getting the temperature from.

In the original MAESTRO, we passed in the temperature.