add wdconvect CI - Githubissues

AMReX-Astro / MAESTROeX

A C++ low Mach number stellar hydrodynamics code

https://amrex-astro.github.io/MAESTROeX/

BSD 3-Clause "New" or "Revised" License

40 stars 22 forks source link

add wdconvect CI #462

Closed zingale closed 3 months ago

zingale commented 3 months ago

closes #449

zingale commented 3 months ago

this gives diffs in the last digit. Not sure why...

biboyd commented 3 months ago

When I run on my machine I get

 vort                         3.7905619114e-13         0.089547619929
 pioverp0                    -1.3133053276e-05       1.3515909745e-05
 circ_velocity                2.4305549801e-15           273571.94181

which agrees with the CI calculation. Seems the benchmark is just off by a bit

zingale commented 3 months ago

probably the compiler version -- I'm using GCC 14.1. I think the CI is using 11.4.

Let me try bumping up the Ubuntu here

zingale commented 3 months ago

okay it passes if we run with Ubuntu 24.04 which uses GCC 13.2.