search

AMReX-Astro / Microphysics

common astrophysical microphysics routines with interfaces for the different AMReX codes
https://amrex-astro.github.io/Microphysics
Other
34 stars 33 forks source link

ener_gener_rate should always appear in the same module #97

Closed zingale closed 3 years ago

zingale commented 6 years ago

It seems the pynucastro nets put ener_gener_rate in actual_network.f90, which most others have it in actual_rhs.f90. This makes it hard to use this routine outside of a net. We should always put it in the same place.

zingale commented 6 years ago

@dwillcox can we chat about this together?

dwillcox commented 6 years ago

I've fixed this in pynucastro. See PR #98 for an updated version of subch.

dwillcox commented 6 years ago

At the moment, this is only on the development branch of pynucastro.

zingale commented 6 years ago

what about the Urca nets?

zingale commented 6 years ago

it looks like this still affects:

ignition_reaclib/C-test ignition_reaclib/URCA-simple ignition_reaclib/C-burn-simple

maxpkatz commented 4 years ago

When do we use ener_gener_rate outside of the RHS?

zingale commented 4 years ago

I no longer remember. Probably in one of the unit tests

maxpkatz commented 4 years ago

OK. I chose not to implement ener_gener_rate explicitly in the C++ port of powerlaw, we can explicitly implement that at some point if we need.

zingale commented 3 years ago

I no longer think that this is an issue.