Closed mwm126 closed 2 years ago
You might want to split this into multiple PRs. Not all changes are fixing warnings. Could you also add more comments or description to the PR? It's not clear why some changes were made.
This PR tried to merge main
into profvis
.
We will try to go the other way in #20 and then remove rename the profvis
branch, as most of its features are merged already.
Hey, is this PR ready? looks like it mainly removes warnings and fixes a couple methods it seems :) Do you like to rebase it once more to remove the merge commits?
ping @WeiqunZhang @kngott for review