search

AMReX-Codes / Amrvis

Amrvis is a visualization package specifically designed to read and display output and profiling data from codes built on the AMReX framework.
https://amrex-codes.github.io/amrex/docs_html/Visualization.html
16 stars 16 forks source link

Profvis #15

Closed mwm126 closed 2 years ago

ax3l commented 2 years ago

Hey, is this PR ready? looks like it mainly removes warnings and fixes a couple methods it seems :) Do you like to rebase it once more to remove the merge commits?

ping @WeiqunZhang @kngott for review

WeiqunZhang commented 2 years ago

You might want to split this into multiple PRs. Not all changes are fixing warnings. Could you also add more comments or description to the PR? It's not clear why some changes were made.

ax3l commented 2 years ago

This PR tried to merge main into profvis.

We will try to go the other way in #20 and then remove rename the profvis branch, as most of its features are merged already.