search

AMReX-Codes / amrex

AMReX: Software Framework for Block Structured AMR
https://amrex-codes.github.io/amrex
Other
519 stars 339 forks source link

Clang-Tidy 17: cppcoreguidelines-rvalue-reference-param-not-moved #3825

Closed WeiqunZhang closed 5 months ago

WeiqunZhang commented 5 months ago

I am in the process of updating to clang-tidy 17. A few more PRs are coming.

On Sun, Mar 24, 2024, 6:25 PM Axel Huebl @.***> wrote:

@.**** approved this pull request.

Great pass.

Want to add the option to our clang tidy file in .clang-tidy?

— Reply to this email directly, view it on GitHub https://github.com/AMReX-Codes/amrex/pull/3825#pullrequestreview-1956728771, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB37TYLL3D2AA5SJRXBVKHTYZ54HLAVCNFSM6AAAAABE6PKTSSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJWG4ZDQNZXGE . You are receiving this because you authored the thread.Message ID: @.***>

WeiqunZhang commented 5 months ago

This particular check is only available in more recent versions of clang-tidy.

On Sun, Mar 24, 2024, 6:55 PM Weiqun Zhang @.***> wrote:

I am in the process of updating to clang-tidy 17. A few more PRs are coming.

On Sun, Mar 24, 2024, 6:25 PM Axel Huebl @.***> wrote:

@.**** approved this pull request.

Great pass.

Want to add the option to our clang tidy file in .clang-tidy?

— Reply to this email directly, view it on GitHub https://github.com/AMReX-Codes/amrex/pull/3825#pullrequestreview-1956728771, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB37TYLL3D2AA5SJRXBVKHTYZ54HLAVCNFSM6AAAAABE6PKTSSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJWG4ZDQNZXGE . You are receiving this because you authored the thread.Message ID: @.***>