AMReX-Codes / regression_testing

The regression test routines for AMReX applications
BSD 3-Clause "New" or "Revised" License
5 stars 24 forks source link

Fix: Branch Param As String #107

Closed ax3l closed 2 years ago

ax3l commented 2 years ago

Branches should always be a string, otherwise tags like 21.12 are parsed as floats, which leads to errors such as:

  File "regression_testing/repo.py", line 38, in get_branch_name
    return self.branch_wanted.strip("\"")
AttributeError: 'float' object has no attribute 'strip'
zingale commented 2 years ago

good catch