search

AMReX-Combustion / PeleC

An AMR code for compressible reacting flow simulations
https://amrex-combustion.github.io/PeleC
Other
162 stars 73 forks source link

abort on unused parmparse variables in input file in tests #725

Closed baperry2 closed 11 months ago

baperry2 commented 11 months ago

So excess/deprecated inputs don't build up and cause confusion.

baperry2 commented 11 months ago

@marchdf @jrood-nrel how do we feel about this? I haven't gone through all the input files yet, but the ones changed here are representative. It catches some deprecated and/or irrelevant inputs, but mostly just catches amr.ref_ratio and amr.regrid_int` for cases without AMR.

jrood-nrel commented 11 months ago

Love it.

marchdf commented 11 months ago

I like it. I wish we could ignore the ref_ratio and regrid_int when max_level = 0. It's less stuff to change when we change the max level... but maybe that's too much to ask?

baperry2 commented 11 months ago

We could put dummy queries for these just so they always get touched, but I'm not a big fan of that. IMO not a big deal just to uncomment those lines when adding levels.

marchdf commented 11 months ago

yeah probably fine.

baperry2 commented 11 months ago

@marchdf based on what this uncovered, it looks like the forcing for HIT case wasn't actually active, which I think I fixed. Also, the "moving plane" EB geometry and corresponding EB-Plane test seem to not really do anything, so I deleted them. Can you double check these changes?

marchdf commented 11 months ago

nice work!