AMReX-Combustion / PeleC

An AMR code for compressible reacting flow simulations
https://amrex-combustion.github.io/PeleC
Other
162 stars 73 forks source link

Diagnostic output parm-parse variables "unused" after restart #747

Closed RSuryaNarayan closed 10 months ago

RSuryaNarayan commented 10 months ago

For debugging purposes, I was trying to restart a case from a checkpoint and change the diagnostic slice file output frequency (by changing pelec.xnormP.int) but it wasn't updating its frequency.

It works fine when I run the case from the beginning.

So after restart, I checked if those diagnostic inputs were even being read-in by running for a single timestep. I get the following message:

Ending run at 16:44:33 UTC on 2024-01-26.
Run time = 9.351523563
Run time w/o init = 9.333585459
Unused ParmParse Variables:
  [TOP]::pelec.diagnostics(nvals = 1)  :: [xNormPlane]
  [TOP]::pelec.xNormPlane.type(nvals = 1)  :: [DiagFramePlane]
  [TOP]::pelec.xNormPlane.file(nvals = 1)  :: [xNormCent]
  [TOP]::pelec.xNormPlane.normal(nvals = 1)  :: [0]
  [TOP]::pelec.xNormPlane.center(nvals = 1)  :: [0.15625]
  [TOP]::pelec.xNormPlane.int(nvals = 1)  :: [5]
  [TOP]::pelec.xNormPlane.field_names(nvals = 10)  :: [density, zmom, xmom, Temp, heatRelease, z_velocity, x_velocity, Y(H2), Y(HO2), pressure]
  [TOP]::pelec.xNormPlane.int(nvals = 1)  :: [1]

Tested this even with PMF case...

baperry2 commented 10 months ago

Good catch, this is a bug. Diagnostics are not presently initialized when restarting from a checkpoint. PR with the fix incoming.

RSuryaNarayan commented 10 months ago

thanks @baperry2 !