AMReX-Combustion / PeleC

An AMR code for compressible reacting flow simulations
https://amrex-combustion.github.io/PeleC
Other
162 stars 73 forks source link

Remove advection from auxiliary quantities B_k #839

Closed dmontgomeryNREL closed 2 months ago

dmontgomeryNREL commented 3 months ago

This PR includes the following:

  1. Fixed a minor typo in the FlowPastCylinder documentation.
  2. Updated the auxiliary quantities ($B_k$ in documented equations) so that they are no longer advected. These equations are identical to the advected quantities $A_k$. The new auxiliary quantities provide users the option to include state variables that are stationary in space. Since these equations were previously identical to the advected quantities, this should not negatively impact users.
  3. Added a test case in RegTests that illustrates how to utilize the advected and auxiliary quantities. I tested the updated code with Godunov, MOL, AMR, and a simple EB.

rho_As_and_Bs

baperry2 commented 3 months ago

Two things:

I am see some movement of one of the stationary scalars where it intersects the EB. Maybe something to do with state redistribution? But it isn't just immediately next to the surface.

Screenshot 2024-09-03 at 12 00 15 PM

Let's have this case run in the CI, similar to what we did for the flow over a cylinder case: https://github.com/AMReX-Combustion/PeleC/pull/827#pullrequestreview-2181243887

dmontgomeryNREL commented 2 months ago

No more movement near the EB! Screenshot 2024-09-05 at 9 06 34 AM

dmontgomeryNREL commented 2 months ago

I removed $\rho$ from the auxiliary quantity equation altogether after discussing a problem with @baperry2 . The new equation is simply $\frac{\partial Bk}{\partial t} = S{ext,B_k}$. I verified the implementation for a simple exponential decay source term at a single point in space. Figure_1