search

AMReX-Combustion / PeleLMeX

An adaptive mesh hydrodynamics simulation code for low Mach number reacting flows without level sub-cycling.
https://amrex-combustion.github.io/PeleLMeX/
BSD 3-Clause "New" or "Revised" License
24 stars 37 forks source link

Fix DiagFramePlane diagnostic #190

Closed esclapez closed 1 year ago

baperry2 commented 1 year ago

Nice. I ran into the issue with ghost cells on the Sydney flame case and worked around it by turning off interpolation. I'll test this fix on that case to make sure it works with interpolation now.

One more thing with diagnostics that I ran into is that if there is a derived variable with multiple components, you have to call out the individual component names rather than the derive name. I was going to look into relaxing that requirement.

esclapez commented 1 year ago

I've been looking at this, and it might be tricky to get the diagnostics to interact with the derived because the intent was to have the diagnostics be as separate as possible in order to move them to PeleAnalysis at some point. I'll try something.

baperry2 commented 1 year ago

I've been looking at this, and it might be tricky to get the diagnostics to interact with the derived because the intent was to have the diagnostics be as separate as possible in order to move them to PeleAnalysis at some point. I'll try something.

It's not a big issue because one can simply list out all the components if desired. But it would be good to throw an error if someone requests a multi-component derive rather than the individual component, because right now that case is not handled properly.