search

AMReX-Combustion / PeleLMeX

An adaptive mesh hydrodynamics simulation code for low Mach number reacting flows without level sub-cycling.
https://amrex-combustion.github.io/PeleLMeX/
BSD 3-Clause "New" or "Revised" License
29 stars 40 forks source link

Add the interface for the radiation module #219

Closed wjge closed 1 year ago

wjge commented 1 year ago

Does PeleLMeX have a .clang-format?

esclapez commented 1 year ago

Hi Wenjun,

It does not, so the formatting requirements are pretty basic: no tabs, no trailing whitespaces. It looks like you have automatically reformatted the files you changed though.

wjge commented 1 year ago

Hi Wenjun,

It does not, so the formatting requirements are pretty basic: no tabs, no trailing whitespaces. It looks like you have automatically reformatted the files you changed though.

Lucas,

Yeah. The automatic clang-format in my vim changed the format. I will try to use the format closer to the majority of original PeleLMeX code.

baperry2 commented 1 year ago

Is there a test case that you can add to this PR to demonstrate? It would also be very helpful to add some documentation on the models and required input file parameters associated with radiation.

wjge commented 1 year ago

Is there a test case that you can add to this PR to demonstrate? It would also be very helpful to add some documentation on the models and required input file parameters associated with radiation.

The test case for the coupled run is in the other PR in PeleMP https://github.com/AMReX-Combustion/PeleMP/pull/14

and a script to build the test case on Frontier can be found here: https://github.com/AMReX-Combustion/PeleMP/blob/00d262d3e75a566a4704ecb312558a7aadc5c5c8/Exec/JetTests/PeleLMeX/xburner_rad/script/build_Frontier.sh

Please let me know, if you have any issue building or running it. Now I am trying to figure out a way to avoid pushing large checkpoint files, all the checkpoint files will be deleted soon in the PeleMP PR.

Although it is called a test, it is more like an example showing how to build and run with radiation. Most 'tests' in PeleMP serve for this purpose. Unit tests are included in the PeleRad repo: https://github.com/AMReX-Combustion/PeleRad

We are documenting the multiphysics in the paper, and plan to add more notes on Github down the road.

esclapez commented 1 year ago

@wjge I'll test your script and move forward on this in the next couple of days.

wjge commented 1 year ago

Close it for now.