search

AMReX-Combustion / PeleLMeX

An adaptive mesh hydrodynamics simulation code for low Mach number reacting flows without level sub-cycling.
https://amrex-combustion.github.io/PeleLMeX/
BSD 3-Clause "New" or "Revised" License
24 stars 32 forks source link

Active Control max velocity default value fix #233

Closed olivecha closed 10 months ago

olivecha commented 10 months ago

The default value for m_ctrl_velMax was set to -1.0 in PeleLM.H

The updated velocity in PeleLMFlowControler.cpp is not limited by the maximum velocity parameter if the parameter value is less than zero.

This result in the active_control.velMax input file parameter being truly optional (see issue #232).

Active control was able to converge without setting the active_control.velMax parameter:

image
baperry2 commented 10 months ago

Thanks for doing this!

Can you also modify the docs here to reflect the slightly updated behavior? https://github.com/AMReX-Combustion/PeleLMeX/blob/62b496ca0abf7bad0ef971cb53fde6eb0226a781/Docs/source/manual/LMeXControls.rst?plain=1#L387C11-L387C11

Closes https://github.com/AMReX-Combustion/PeleLMeX/issues/232