AMReX-Combustion / PeleLMeX

An adaptive mesh hydrodynamics simulation code for low Mach number reacting flows without level sub-cycling.
https://amrex-combustion.github.io/PeleLMeX/
BSD 3-Clause "New" or "Revised" License
24 stars 32 forks source link

Update PelePhysics - Use Sundials submod in gmake #235

Closed baperry2 closed 10 months ago

baperry2 commented 10 months ago

This will fix an error where make TPL fails. Mirrors PeleC https://github.com/AMReX-Combustion/PeleC/pull/686

jrood-nrel commented 10 months ago

I think the cloning in the CI files need to clone the submodules now as well

jrood-nrel commented 10 months ago

We also need to make the CI more efficient here and have it use CMake soon.

baperry2 commented 10 months ago

Yeah it would be nice to have the CI match up better between C and LMeX

jrood-nrel commented 10 months ago

Looks like SUNDIALS_HOME needs to be set in all the other CI files.