Joss review update - Githubissues

AMReX-Combustion / PeleLMeX

An adaptive mesh hydrodynamics simulation code for low Mach number reacting flows without level sub-cycling.

https://amrex-combustion.github.io/PeleLMeX/

BSD 3-Clause "New" or "Revised" License

24 stars 32 forks source link

Joss review update #236

Closed esclapez closed 9 months ago

esclapez commented 10 months ago

Hi @baperry2 @nickwimer !

This PR address most of the issues raised by the JOSS reviewers:

refactoring of the main README for completeness
re-arranging the Exec/RegTests READMEs
reducing the number of typo
adding a small tutorial on the HotBubble case

I'll get cracking on the change to the paper itself in the JOSS_paper branch.

baperry2 commented 10 months ago

I merged in changes required to get tests to pass since something broke with using wget to get sundials. As a result, there's another environment variable (SUNDIALS_PATH) that can optionally be specified. I'll propagate that change into the readme, tutorials, etc. I also see a small typos, I'll try to get those as well before this gets merged.