Fix no EB production cases

AMReX-Combustion / PeleLMeX

An adaptive mesh hydrodynamics simulation code for low Mach number reacting flows without level sub-cycling.

https://amrex-combustion.github.io/PeleLMeX/

BSD 3-Clause "New" or "Revised" License

28 stars 40 forks source link

Fix no EB production cases #314

Closed baperry2 closed 10 months ago

baperry2 commented 10 months ago

Don't compile with EB for Production cases that don't need it. Alternatively, we could still compile with EB but set eb2.geom_type = all_regular in the input files.

Closes #311

jrood-nrel commented 10 months ago

I would love to remove the EB ifdef and use all_regular like we do in PeleC sometime.

esclapez commented 10 months ago

It won't work as well for LMeX (removing the EB ifdef). The linear solvers are completely different for EB, with different algorithms even when all_regular (especially the nodal solver). The plain linear solvers are faster than the EB versions and the EB versions are not fully available with kernel-fusing ParFor, so they tend to scale not as good. Probably nothing you couldn't fix with time though.